[webkit-reviews] review granted: [Bug 103250] [Qt] Build fails due to usage of removed QApplication::GuiServer : [Attachment 175991] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 26 22:48:18 PST 2012


Simon Hausmann <hausmann at webkit.org> has granted Milian Wolff
<milian.wolff at kdab.com>'s request for review:
Bug 103250: [Qt] Build fails due to usage of removed QApplication::GuiServer
https://bugs.webkit.org/show_bug.cgi?id=103250

Attachment 175991: Patch
https://bugs.webkit.org/attachment.cgi?id=175991&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175991&action=review


> Tools/ChangeLog:8
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).

That line should be replaced with something more descriptive ;-)

That said, I'm okay with the change. Please fix the changelog before landing or
upload a new patch.


More information about the webkit-reviews mailing list