[webkit-reviews] review denied: [Bug 103297] Coordinated Graphics: Refactor code related to mask and replication. : [Attachment 176145] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 103297: Coordinated Graphics: Refactor code related to mask and
replication.
https://bugs.webkit.org/show_bug.cgi?id=103297

Attachment 176145: Patch
https://bugs.webkit.org/attachment.cgi?id=176145&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176145&action=review


We shouldn't traverse mask and replica layers in this way. 
Backing store for masks depend on their owning layer, and replica layers don't
have a backing store. We should make more conscious decisions about this rather
than traverse everything.

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:57
> +    if (m_state.replicaLayer)
> +	   m_state.replicaLayer->clearBackingStoresRecursive();

A replica layer never has a backing store.