[webkit-reviews] review granted: [Bug 103031] Better type ahead for DateTimeSymbolicFieldElement : [Attachment 175981] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 26 18:18:36 PST 2012


Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 103031: Better type ahead for DateTimeSymbolicFieldElement
https://bugs.webkit.org/show_bug.cgi?id=103031

Attachment 175981: Patch
https://bugs.webkit.org/attachment.cgi?id=175981&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175981&action=review


> Source/WebCore/html/TypeAhead.h:59
> +    void setMatchMode(MatchModeFlags);

nit: We can remove setMatchMode and m_matchMode by adding MatchModeFlags
argument to handleEvent.
It's up to you to do it.


More information about the webkit-reviews mailing list