[webkit-reviews] review granted: [Bug 101780] objc/objc-runtime.h does not exist on all PLATFORM(MAC) : [Attachment 176101] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 26 17:38:37 PST 2012


Brent Fulgham <bfulgham at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 101780: objc/objc-runtime.h does not exist on all PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=101780

Attachment 176101: Patch
https://bugs.webkit.org/attachment.cgi?id=176101&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176101&action=review


Looks good to me.  The mac EWS hasn't completed, but I assume you probably
already did the Apple Mac and iOS builds locally.

> Source/WebKit/mac/Carbon/HIWebView.mm:1169
> +			   if (wtfObjcMsgSend<BOOL>(resp,
@selector(validateUserInterfaceItem:), proxy))

Cool!  I didn't know about this template.


More information about the webkit-reviews mailing list