[webkit-reviews] review requested: [Bug 103295] TextIterator unnecessarily converts 8 bit strings to 16 bits : [Attachment 176103] Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 103295: TextIterator unnecessarily converts 8 bit strings to 16 bits
https://bugs.webkit.org/show_bug.cgi?id=103295

Attachment 176103: Patch
https://bugs.webkit.org/attachment.cgi?id=176103&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
This change is a progression on the performance test attached to
https://bugs.webkit.org/show_bug.cgi?id=81192 referenced in the code.
Comparing the geometric mean of 3 runs before and after the patch:
	   Baseline   With Patch   Delta
innerText:  3676.2ms	  3032.87ms   +17%
outerText:  3625.7ms	  3603.27ms    +0.6%

It is also great improvement on the number of strings/characters that need to
be up converted to 16 bits in our page load memory test.

Before, 21289 (10.73%) strings up converted totaling 432,175 characters using
864,350 bytes
After, 2201 ( 1.08%) strings up converted totaling 82,394 characters using
164,788 bytes
This is a 90% reduction of strings and an 81% reduction in characters / bytes.