[webkit-reviews] review granted: [Bug 101815] Add basic implementation for MediaStreamAudioDestinationNode : [Attachment 175954] Patch

[bugzilla-daemon at webkit.org]

Chris Rogers <crogers at google.com> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 101815: Add basic implementation for MediaStreamAudioDestinationNode
https://bugs.webkit.org/show_bug.cgi?id=101815

Attachment 175954: Patch
https://bugs.webkit.org/attachment.cgi?id=175954&action=review

------- Additional Comments from Chris Rogers <crogers at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=175954&action=review


looks good

>> Source/Platform/chromium/public/WebAudioDestinationConsumer.h:32
>> +class WebAudioDestinationConsumer {
> 
> What does the word "destination" mean here?  This seems like it could be
sensibly called a WebAudioConsumer.

This seems fine to me since AudioDestinationConsumer is symmetric/consistent
with AudioSourceProvider.