[webkit-reviews] review granted: [Bug 102446] Make StyleResolver::applyProperty use isInherit in CSSPropertyWebkitMarquee instead of calculating equivalent in-place. : [Attachment 174555] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 102446: Make StyleResolver::applyProperty use isInherit in
CSSPropertyWebkitMarquee instead of calculating equivalent in-place.
https://bugs.webkit.org/show_bug.cgi?id=102446

Attachment 174555: Patch
https://bugs.webkit.org/attachment.cgi?id=174555&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174555&action=review


>>> Source/WebCore/ChangeLog:8
>>> +	     !m_parentNode || !value->isInheritedValue() is equivalent to
!isInherit (by De Morgan's law).
>> 
>> Would it make sense to ASSERT it?
> 
> Not really. It's a mathematical certainty. This is likely a case where the
original author was simply unaware of isInherit.

FWIW, refactoring could cause this to get out of sync, so I don't think it
would hurt.  That said, we don't do that for other cases in the switch, so it's
probably not a big deal.