[webkit-reviews] review denied: [Bug 103168] [WK2] Add null check and early return code before accessing member of m_iconDatabaseImpl if IconDatabase is not created yet : [Attachment 175919] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 26 11:56:50 PST 2012
Anders Carlsson <andersca at apple.com> has denied Changhyup Jwa
<ch.jwa at samsung.com>'s request for review:
Bug 103168: [WK2] Add null check and early return code before accessing member
of m_iconDatabaseImpl if IconDatabase is not created yet
https://bugs.webkit.org/show_bug.cgi?id=103168
Attachment 175919: Patch
https://bugs.webkit.org/attachment.cgi?id=175919&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
I agree with Alexey here, m_iconDatabaseImpl should never be null. If it is for
some reason, then that underlying issue should be fixed instead of papering
over it with random null checks.
More information about the webkit-reviews
mailing list