[webkit-reviews] review granted: [Bug 102385] [CSS Regions] Absolutely positioned region does not expand to fill its container : [Attachment 175851] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 102385: [CSS Regions] Absolutely positioned region does not expand to fill
its container
https://bugs.webkit.org/show_bug.cgi?id=102385

Attachment 175851: Patch
https://bugs.webkit.org/attachment.cgi?id=175851&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175851&action=review


> LayoutTests/ChangeLog:3
> +	   [CSS Regions] Absolutely positioned region does not expand to fill
its container

Nit: The name sounds weird to me (non-native English speaker though), either
missing a leading "An" or a generic plural (Absolutely positioned regions do
not ...).

Also the name could be improved: you are fixing the case where you have set
your logical height and we wouldn't be expanding in the logical width.

> LayoutTests/fast/regions/autosize-abspos-anchoredregion.html:6
> +	       .region { -webkit-flow-from: flow; position: absolute; top: 0px;
left: 0px; right: 0px; bottom: 0px; background-color: green; }

You are over-constraining your region in most cases below as you have top &
bottom, left & right set at the same time, which forces the size of your
element.

> LayoutTests/fast/regions/autosize-abspos-anchoredregion.html:19
> +	   </style>

A good addition would be a vertical writing-mode test for that too.