[webkit-reviews] review denied: [Bug 102359] Caret is painted horizontally in vertical writing mode when there are no visible text : [Attachment 175989] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 26 09:56:13 PST 2012


Ryosuke Niwa <rniwa at webkit.org> has denied Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 102359: Caret is painted horizontally in vertical writing mode when there
are no visible text
https://bugs.webkit.org/show_bug.cgi?id=102359

Attachment 175989: Patch
https://bugs.webkit.org/attachment.cgi?id=175989&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175989&action=review


> LayoutTests/editing/selection/caret-alignment-for-vertical-text.html:31
> +    document.execCommand('InsertParagraph');

Again, we shouldn't have to run an execCommand here. Just hard-code the DOM
after inserting paragraph and use that.


More information about the webkit-reviews mailing list