[webkit-reviews] review granted: [Bug 103222] Web Inspector: object preview does not render node id, className; logs too many functions for jQuery. : [Attachment 175939] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 26 01:59:28 PST 2012


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 103222: Web Inspector: object preview does not render node id, className;
logs too many functions for jQuery.
https://bugs.webkit.org/show_bug.cgi?id=103222

Attachment 175939: Patch
https://bugs.webkit.org/attachment.cgi?id=175939&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175939&action=review


> Source/WebCore/inspector/InspectorOverlayPage.html:91
> +    /* Keep this in sync with view-source.css (.webkit-html-attribute-value)
*/

can we declare this style once and enumerate all selectors, like this:
#node-id, .webkit-html-attribute-value, .node-id {...}
?

> Source/WebCore/inspector/InspectorOverlayPage.html:349
> +    document.getElementById("class-name").textContent = className || "";

className || "" -> className ?


More information about the webkit-reviews mailing list