[webkit-reviews] review denied: [Bug 103031] Better type ahead for DateTimeSymbolicFieldElement : [Attachment 175941] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 103031: Better type ahead for DateTimeSymbolicFieldElement
https://bugs.webkit.org/show_bug.cgi?id=103031

Attachment 175941: Patch
https://bugs.webkit.org/attachment.cgi?id=175941&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175941&action=review


> Source/WebCore/ChangeLog:16
> +	   * WebCore.gypi: Added TypeAhead.{h,cpp}

You need to add these files to many other build files.

> Source/WebCore/html/HTMLSelectElement.h:111
> +    // TypeAheadDataSource methods.
> +    virtual int indexOfSelectedOption() const OVERRIDE;
> +    virtual int optionCount() const OVERRIDE;
> +    virtual String optionAtIndex(int index) const OVERRIDE;

Let's make them private because they shouldn't be called by non-TypeAhead code.


> Source/WebCore/html/TypeAhead.cpp:2
> + * Copyright (C) 2012 Google Inc. All rights reserved.

You have to respect the copyright of the original code.