[webkit-reviews] review denied: [Bug 101605] Web Inspector: Add UA Strings for iOS6 as well as IE Mobile 9 & 10 : [Attachment 175794] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Konrad Piascik
<kpiascik at rim.com>'s request for review:
Bug 101605: Web Inspector: Add UA Strings for iOS6 as well as IE Mobile 9 & 10
https://bugs.webkit.org/show_bug.cgi?id=101605

Attachment 175794: Patch
https://bugs.webkit.org/attachment.cgi?id=175794&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175794&action=review


> Source/WebCore/inspector/front-end/SettingsScreen.js:429
> +	       ["Android 4.0.2 \u2014 Galaxy Nexus", "Mozilla/5.0 (Linux; U;
Android 4.0.2; en-us; Galaxy Nexus Build/ICL53F) AppleWebKit/534.30 (KHTML,
like Gecko) Version/4.0 Mobile Safari/534.30", "720x1280x1.1"],

Version sorting is messed up: IE and IOS versions are in descending order,
Android versions are in ascending one while FF versions are in a mixed order.
We should sort them consistently, probably using Array.sort and adding
"Other..." to the end?