[webkit-reviews] review granted: [Bug 102610] Extend EventDispatcher::dispatchSimulatedClick to allow sending a mouseover event : [Attachment 174865] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 102610: Extend EventDispatcher::dispatchSimulatedClick to allow sending a
mouseover event
https://bugs.webkit.org/show_bug.cgi?id=102610

Attachment 174865: Patch
https://bugs.webkit.org/attachment.cgi?id=174865&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=174865&action=review


> Source/WebCore/dom/EventDispatcher.cpp:226
> +    if (mouseEventOptions > SendNoEvents)

This seems fragile. If someone adds a new value to the enum they won’t realize
that the order of enum values matters. I suggest writing this differently.

> Source/WebCore/dom/EventDispatcher.cpp:229
> +    if (mouseEventOptions > SendNoEvents)

Same comment as above.

> Source/WebCore/dom/EventDispatcher.h:29
> +#include "Node.h"

I don’t think we want to pull in the whole Node.h header to every file that
includes EventDispatcher.h. We should find some other way to get the enum in
the right files.