[webkit-reviews] review denied: [Bug 101545] LongPress and LongTap gestures should start drag/drop and open context menu respectively. : [Attachment 175899] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied Varun Jain
<varunjain at chromium.org>'s request for review:
Bug 101545: LongPress and LongTap gestures should start drag/drop and open
context menu respectively.
https://bugs.webkit.org/show_bug.cgi?id=101545

Attachment 175899: Patch
https://bugs.webkit.org/attachment.cgi?id=175899&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175899&action=review


> Source/WebCore/page/EventHandler.cpp:2658
> +#if ENABLE(DRAG_SUPPORT)
> +    if (m_frame->settings()->touchDragDropEnabled()) {

Did you add an explanation to the changelog? I remember you mentioning
something about a "developers' menu" that would allow users to toggle it
on/off?

also does "touch drag&drop" means: use the same code that handles drag&drop for
mouse events, but with touch (gesture) events?

> Source/WebCore/page/Settings.h:299
> +	   void setTouchDragDropEnabled(bool enabled) { m_touchDragDropEnabled
= enabled; }
> +	   bool touchDragDropEnabled() { return m_touchDragDropEnabled; }

do not we have Settings.in to be modified instead now?

> Source/WebCore/page/Settings.h:376
> +	   bool m_touchDragDropEnabled;

why not bitfy it like the other bools?