[webkit-reviews] review denied: [Bug 102300] Add a new shared class WebCoreFullScreenPlaceholderView, for use in WebKit and WebKit2. : [Attachment 174292] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 102300: Add a new shared class WebCoreFullScreenPlaceholderView, for use in
WebKit and WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=102300

Attachment 174292: Patch
https://bugs.webkit.org/attachment.cgi?id=174292&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174292&action=review


> Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:84
> +    [_exitWarning.get() setHidden:!visible];
> +    if (visible) {
> +	   CIFilter* filter = [CIFilter filterWithName:@"CIFalseColor"
keysAndValues:
> +			       @"inputColor0", [CIColor colorWithRed:0 green:0
blue:0],
> +			       @"inputColor1", [CIColor colorWithRed:.9
green:.9 blue:.9],
> +			       nil];
> +	   [[self layer] setCompositingFilter:filter];
> +    } else
> +	   [[self layer] setCompositingFilter:nil];

We should try to do this without using CoreImage.  CoreImage doesn't play nice
with our layer hosting strategy.