[webkit-reviews] review granted: [Bug 103190] [BlackBerry] Find-on-page keeps stale pointer : [Attachment 175869] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 24 17:17:13 PST 2012


Rob Buis <rwlbuis at gmail.com> has granted Andy Chen <andchen at rim.com>'s request
for review:
Bug 103190: [BlackBerry] Find-on-page keeps stale pointer
https://bugs.webkit.org/show_bug.cgi?id=103190

Attachment 175869: Patch
https://bugs.webkit.org/attachment.cgi?id=175869&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=175869&action=review


LGTM.

> Source/WebKit/blackberry/WebKitSupport/InPageSearchManager.cpp:251
> +    for (size_t i = 0; i < m_deferredScopingWork.size(); i++) {

pre-increment is more efficient.


More information about the webkit-reviews mailing list