[webkit-reviews] review granted: [Bug 101545] LongPress and LongTap gestures should start drag/drop and open context menu respectively. : [Attachment 175829] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 23 11:59:24 PST 2012
Antonio Gomes <tonikitoo at webkit.org> has granted Varun Jain
<varunjain at chromium.org>'s request for review:
Bug 101545: LongPress and LongTap gestures should start drag/drop and open
context menu respectively.
https://bugs.webkit.org/show_bug.cgi?id=101545
Attachment 175829: Patch
https://bugs.webkit.org/attachment.cgi?id=175829&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
<tonikitoo> what is the difference between m_didStartDrag and the return value
or ::handleDrag?
[15:51] <varunjain> I think handleDrag is very inclusive.. it returns false
only if the event is not a left mouse button drag... it does not necessarily
return true only when a drag was actually started
[15:53] <tonikitoo> so it might return TRUE even if dragging actually did not
start
[15:53] <tonikitoo> ?
[15:58] <varunjain> yes
More information about the webkit-reviews
mailing list