[webkit-reviews] review denied: [Bug 102543] ScrollingCoordinator::hasVisibleSlowRepaintFixedObject() should exclude out-of-view fixed position elements : [Attachment 175255] For review
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 23 11:28:53 PST 2012
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 102543: ScrollingCoordinator::hasVisibleSlowRepaintFixedObject() should
exclude out-of-view fixed position elements
https://bugs.webkit.org/show_bug.cgi?id=102543
Attachment 175255: For review
https://bugs.webkit.org/attachment.cgi?id=175255&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=175255&action=review
> Source/WebCore/rendering/RenderLayerModelObject.h:65
> + bool m_isOutOfViewFixedPositioned : 1;
I don't think we should waste a member variable for this state which only
applies to position:fixed elements for some ports; it probably increases the
size of the class, possibly by 4 bytes. Please measure.
More information about the webkit-reviews
mailing list