[webkit-reviews] review granted: [Bug 103125] tst_qwebpage fails after QMimeDatabase patch : [Attachment 175777] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 23 05:18:45 PST 2012


Simon Hausmann <hausmann at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 103125: tst_qwebpage fails after QMimeDatabase patch
https://bugs.webkit.org/show_bug.cgi?id=103125

Attachment 175777: Patch
https://bugs.webkit.org/attachment.cgi?id=175777&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175777&action=review


>> Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2992
>> +   contentTypes << "application/x-mimearchive";
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent? 
[whitespace/indent] [3]

This is indeed a three character indent instead of four. Please fix before
landing :)


More information about the webkit-reviews mailing list