[webkit-reviews] review canceled: [Bug 102889] WebSocket's MessageEvent.origin attribute is an empty string : [Attachment 175753] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 23 02:33:04 PST 2012
Christophe Dumez <christophe.dumez at intel.com> has canceled Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 102889: WebSocket's MessageEvent.origin attribute is an empty string
https://bugs.webkit.org/show_bug.cgi?id=102889
Attachment 175753: Patch
https://bugs.webkit.org/attachment.cgi?id=175753&action=review
------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=175753&action=review
>> LayoutTests/http/tests/websocket/tests/hybi/send-once_wsh.py:2
>> +# Copyright (C) 2012 Intel Corporation. All rights reserved.
>
> Is this copyright correct? If this is a new file, the copyright would be
intel's one.
Well, this is basically a simplified version of
LayoutTests/http/tests/websocket/tests/hybi/send_wsh.py, which expects 1
message instead of 2. Since the original file was with Google copyright and the
code is mostly the same, I kept the copyright.
Anyway, it does not really matter since you prefer I use existing
infrastructure. I guess I'll use
LayoutTests/http/tests/websocket/tests/hybi/send_wsh.py and send 2 messages.
More information about the webkit-reviews
mailing list