[webkit-reviews] review denied: [Bug 103096] REGRESSION(r135493): HTMLCollection and DynamicNodeList have two vtable pointers : [Attachment 175736] rniwa's patch with chromium compilation fix and native memory instrumentation fix

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 103096: REGRESSION(r135493): HTMLCollection and DynamicNodeList have two
vtable pointers
https://bugs.webkit.org/show_bug.cgi?id=103096

Attachment 175736: rniwa's patch with chromium compilation fix and native
memory instrumentation fix
https://bugs.webkit.org/attachment.cgi?id=175736&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175736&action=review


> Source/WebCore/dom/DynamicNodeList.h:44
> -class DynamicNodeListCacheBase {
> +class DynamicNodeListCacheBase : public NodeList {

Now HTMLCollection has two copies of ScriptWrappable as a base clase: one from
NodeList and one from HTMLCollection.  You can just remove the one in
HTMLCollection.