[webkit-reviews] review granted: [Bug 103061] [V8] Move WorkerExecutionContextProxy::initializeIfNeeded() to V8Initializer : [Attachment 175655] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 103061: [V8] Move WorkerExecutionContextProxy::initializeIfNeeded() to
V8Initializer
https://bugs.webkit.org/show_bug.cgi?id=103061

Attachment 175655: Patch
https://bugs.webkit.org/attachment.cgi?id=175655&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175655&action=review


> Source/WebCore/bindings/v8/V8Initializer.cpp:158
> +void V8Initializer::initializeWorkerIfNeeded()

Why is this "if needed"?  It seems like it always does the initialization.

> Source/WebCore/bindings/v8/V8Initializer.h:37
> +    static const int kWorkerMaxStackSize = 500 * 1024;

Why not just make this a static constant in V8Initializer.cpp ?