[webkit-reviews] review granted: [Bug 98633] max-height property not respected in case of tables : [Attachment 175179] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Pravin D
<pravind.2k4 at gmail.com>'s request for review:
Bug 98633: max-height property not respected in case of tables
https://bugs.webkit.org/show_bug.cgi?id=98633

Attachment 175179: Patch
https://bugs.webkit.org/attachment.cgi?id=175179&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175179&action=review


> Please let me know if your opinion on the same. Maybe if you feel that the
height of table should not exceed max-height in any case

OK, FF and IE match this behavior. Opera has a weird behavior.

> LayoutTests/fast/table/css-table-max-height.html:101
> +    <div class="child fixed-table" style="max-height:100px;"
data-expected-height=192>
> +	   This sub-test checks that when content height is greater than
max-height, content height is applied to a table with fixed layout.
> +	   <br><br>FILLER TEXT TO INCREASE CONTENT HEIGHT.

Note that this makes the test dependent on the text size. Hopefully this
shouldn't make the test platform-dependent.