[webkit-reviews] review granted: [Bug 103088] Remove SVGShadowText : [Attachment 175709] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 103088: Remove SVGShadowText
https://bugs.webkit.org/show_bug.cgi?id=103088

Attachment 175709: patch
https://bugs.webkit.org/attachment.cgi?id=175709&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175709&action=review


> Source/WebCore/dom/Text.cpp:242
> +static bool isSVGShadowText(Text* text)

I would add inline if I were you.

> Source/WebCore/dom/Text.cpp:248
> +static bool isSVGText(Text* text)

Ditto.

> Source/WebCore/svg/SVGTRefElement.cpp:162
>	   root->firstChild()->setTextContent(textContent,
ASSERT_NO_EXCEPTION);

We should probably assert that firstChild is a Text node.