[webkit-reviews] review denied: [Bug 102659] Web Inspector: Refactoring: replace fixed distribution with subscription for main thread monitoring events. : [Attachment 174940] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 102659: Web Inspector: Refactoring: replace fixed distribution with
subscription for main thread monitoring events.
https://bugs.webkit.org/show_bug.cgi?id=102659

Attachment 174940: Patch
https://bugs.webkit.org/attachment.cgi?id=174940&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174940&action=review


> Source/WebCore/ChangeLog:9
> +	   "Fixed" distribution model doesn't match very well for that.

The way it works is: WebCore issues instrumentation signals via
InspectorInstrumentation::, the latter dispatches it to the interested parties
(agents). I don't think you should change this model for these two signals
only, it is more important that everything is consistent. We can talk about
making entire Instrumentation infrastructure subscription-based, but that is a
way more complex story.

For now, you should just send signal to the profiler agent (or any other agent
you need to deliver task info to).