[webkit-reviews] review granted: [Bug 103060] Eliminate EditingText : [Attachment 175666] patch 2

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 103060: Eliminate EditingText
https://bugs.webkit.org/show_bug.cgi?id=103060

Attachment 175666: patch 2
https://bugs.webkit.org/attachment.cgi?id=175666&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175666&action=review


> Source/WebCore/dom/Node.h:320
> +    bool hasName() const { ASSERT(!isTextNode()); return
getFlag(HasNameOrIsEditingTextFlag); }

These two statements should probably be put in separate lines.

> Source/WebCore/dom/Node.h:334
> +    bool isEditingText() const { ASSERT(isTextNode()); return
getFlag(HasNameOrIsEditingTextFlag); }

Ditto.

> Source/WebCore/dom/Node.h:336
> +    void setHasName(bool f) { ASSERT(!isTextNode()); setFlag(f,
HasNameOrIsEditingTextFlag); }

Ditto.