[webkit-reviews] review granted: [Bug 103038] Web Inspector: Simplify script mappings by introducing DefaultScriptMapping. : [Attachment 175625] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 103038: Web Inspector: Simplify script mappings by introducing
DefaultScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=103038

Attachment 175625: Patch
https://bugs.webkit.org/attachment.cgi?id=175625&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175625&action=review


> Source/WebCore/ChangeLog:8
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).

Remove this line.

> Source/WebCore/inspector/front-end/DefaultScriptMapping.js:55
> +	   return new WebInspector.UILocation(uiSourceCode, lineNumber,
columnNumber);

We should finally make it a factory method on UISourceCode.