[webkit-reviews] review denied: [Bug 103046] [TexMap] Remove dependency of TextureMapperLayer on GraphicsLayerTextureMapper. : [Attachment 175636] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 22 06:15:35 PST 2012


Noam Rosenthal <noam at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 103046: [TexMap] Remove dependency of TextureMapperLayer on
GraphicsLayerTextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=103046

Attachment 175636: Patch
https://bugs.webkit.org/attachment.cgi?id=175636&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175636&action=review


Looks really good! Seems like it's missing some Timer.h includes though :)

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:57
> +    , m_shouldManageBackingStore(true)

m_hasOwnBackingStore

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:475
> +

Empty line


More information about the webkit-reviews mailing list