[webkit-reviews] review denied: [Bug 103012] [V8] Remove return values of macros in V8BindingMacros.h : [Attachment 175574] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied	review:
Bug 103012: [V8] Remove return values of macros in V8BindingMacros.h
https://bugs.webkit.org/show_bug.cgi?id=103012

Attachment 175574: Patch
https://bugs.webkit.org/attachment.cgi?id=175574&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175574&action=review


> Source/WebCore/bindings/v8/V8BindingMacros.h:-59
> -	   return v8::Undefined();

Oh, removing 'v8::Undefined()' is fine but removing 'return' is not fine here.

Either way it looks like I need to think about a whole plan of
EXCEPTION_BLOCK()s refactoring before making ad-hoc improvements.

My goal would be implementing the following methods:

double v8ValueToNumber(Handle<Value> value) {
  if (value->IsNumber())
    return value->NumberValue();
  v8::TryCatch block;
  double d = value->NumberValue();
  if (block.HasCaught())
    block.ReThrow();
  return d;
}

double v8ValueToInt32(Handle<Value> value) {
  ...;
}