[webkit-reviews] review granted: [Bug 102667] [Qt] Lookup mimetypes using QMimeDatabase : [Attachment 175645] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 102667: [Qt] Lookup mimetypes using QMimeDatabase
https://bugs.webkit.org/show_bug.cgi?id=102667

Attachment 175645: Patch
https://bugs.webkit.org/attachment.cgi?id=175645&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175645&action=review


r=me with comments. Nice to see the list of hardcoded types finally go away!

> Source/WebCore/platform/qt/MIMETypeRegistryQt.cpp:41
> +    const String filename = "filename." + ext.lower();

Since the only thing we do is to take the filename and convert it
(allocatingly) to a QString, I suppose you could also construct a QString here
right away.

> Source/WebCore/platform/qt/MIMETypeRegistryQt.cpp:56
> +    return "application/octet-stream";

Why not return defaultMIMEType() here and safe the string construction? :)