[webkit-reviews] review granted: [Bug 103033] INPUT_MULTIPLE_FIELDS_UI: Refactoring: Do not call updateInnerTextValue if only read-only sub-fields have values : [Attachment 175615] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 103033: INPUT_MULTIPLE_FIELDS_UI: Refactoring: Do not call
updateInnerTextValue if only read-only sub-fields have values
https://bugs.webkit.org/show_bug.cgi?id=103033

Attachment 175615: Patch
https://bugs.webkit.org/attachment.cgi?id=175615&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175615&action=review


>
LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empt
y.html:23
> +shouldNotBe('eventSender.keyDown("upArrow");
getUserAgentShadowTextContent(input)', 'initialText');

Instead of shouldNotBe(), how about dumping the value of
getUserAgentShadowTextContent(input) ? Given that you're dumping initialText,
the test result is already platform-dependent.