[webkit-reviews] review denied: [Bug 102914] [WK2] Support download attribute feature : [Attachment 175405] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied KyungTae Kim
<ktf.kim at samsung.com>'s request for review:
Bug 102914: [WK2] Support download attribute feature
https://bugs.webkit.org/show_bug.cgi?id=102914

Attachment 175405: Patch
https://bugs.webkit.org/attachment.cgi?id=175405&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
I don't think this feature is in good enough shape to be making changes to
cross platform code, especially when that code isn't solely contained to the
feature.

As-is we treat the click on such a link as an *order* to the user agent to
download.  We need this to be a *REQUEST* for the user agent to download. 

We need to implement the cross-origin protection described in the spec, and
*should* implement the "content-disposition header can overwrite the filename"
part of the spec.  Doing both of those means starting the load as a normal main
resource load and waiting until the response headers come in.

We should pipe it through the normal policy delegate callbacks at that point. 
The change there needs to be that the policy delegate knows this was
*requested* to be a download with a certain filename, but the user agent still
gets to decide.

And all of those things said, we need layouttest coverage that monitors the
policy delegate's actual decision instead of assuming that a click on one of
these should automatically be a download.