[webkit-reviews] review denied: [Bug 102045] Add week-multiple-fields tests : [Attachment 175594] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 102045: Add week-multiple-fields tests
https://bugs.webkit.org/show_bug.cgi?id=102045

Attachment 175594: Patch
https://bugs.webkit.org/attachment.cgi?id=175594&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175594&action=review


>
LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attrib
utes.html:36
> +    testInput.parentNode.removeChild(testInput);

nit: You can do it with testInput.remove().

>
LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-ax-value-chang
ed-notification.html:31
> +	   testInput.parentNode.removeChild(testInput);

nit: you can do it with testInput.remove().

>
LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-change-layout-
by-value.html:21
> +document.body.removeChild(testInput);

ditto.

>
LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-keyboard-event
s-expected.txt:24
> +FAIL input.value should be 2012-W52. Was 2013-W52.

FAIL

>
LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-keyboard-event
s.html:65
> +// FIXME: We should test type ahead time out. When event.leapForward()
affects
> +// keyboard event time stamp, we can uncomment this fragment.
> +/*
> +beginTest('Digit keys with type ahead timeout');
> +keyDown('1'); // -> [01]/dd/yyyy
> +leapForward(1100); // -> 01/[dd]/yyyy
> +keyDown('1'); // -> 01/[01]/yyyy
> +keyDown('5'); // -> 01/15/[yyyy]
> +keyDown('6'); // -> 01/15/[0006]
> +shouldBeEqualToString('input.value', '0006-01-15');
> +*/

Please update this block for type=week, or remove it.

>
LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-keyboard-event
s.html:89
> +keyDown('upArrow'); //    -> Week 52, [0001]

The result will be Week 52, [currentYear].

>
LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-wheel-event.ht
ml:10
> +    'inputType' : 'date',

should be 'week'