[webkit-reviews] review granted: [Bug 102967] Make CachedSVGDocumentReference independent of FilterOperation : [Attachment 175495] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 102967: Make CachedSVGDocumentReference independent of FilterOperation
https://bugs.webkit.org/show_bug.cgi?id=102967

Attachment 175495: Patch
https://bugs.webkit.org/attachment.cgi?id=175495&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=175495&action=review


r=me

> Source/WebCore/platform/graphics/filters/FilterOperation.h:-169
> -    class Data {
> -    public:
> -	   virtual ~Data() { }
> -    };

Huh. Good to kill this.

> Source/WebCore/rendering/FilterEffectRenderer.cpp:125
>  PassRefPtr<FilterEffect>
FilterEffectRenderer::buildReferenceFilter(Document* document,
PassRefPtr<FilterEffect> previousEffect, ReferenceFilterOperation* op)

'filterOperation' would be a better name than 'op'