[webkit-reviews] review denied: [Bug 102968] Support proper <percent> / calc() resolution for grid items : [Attachment 175533] Same patch but fixed a dumb typo in expected files.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 21 15:37:42 PST 2012
Ojan Vafai <ojan at chromium.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 102968: Support proper <percent> / calc() resolution for grid items
https://bugs.webkit.org/show_bug.cgi?id=102968
Attachment 175533: Same patch but fixed a dumb typo in expected files.
https://bugs.webkit.org/attachment.cgi?id=175533&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175533&action=review
Confused...
> Source/WebCore/rendering/RenderGrid.cpp:180
> + setLogicalWidth(columnTracks[columnTrack].m_usedBreadth);
I don't think this is right. Where in the spec does it say that the grids width
is sized to it's contents?
> Source/WebCore/rendering/RenderGrid.cpp:193
> + setLogicalWidth(currentLogicalWidth);
> + setLogicalHeight(currentLogicalHeight);
Why do we set the width and height just to set them back to their original
values?
More information about the webkit-reviews
mailing list