[webkit-reviews] review granted: [Bug 102978] [BlackBerry] Prevent screen from dimming on device when inspector front-end is connected : [Attachment 175519] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Konrad Piascik <kpiascik at rim.com>'s
request for review:
Bug 102978: [BlackBerry] Prevent screen from dimming on device when inspector
front-end is connected
https://bugs.webkit.org/show_bug.cgi?id=102978

Attachment 175519: Patch
https://bugs.webkit.org/attachment.cgi?id=175519&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=175519&action=review


LGTM.

> Source/WebKit/blackberry/Api/WebPage.cpp:5223
> +    d->setPreventsScreenDimming(true);

Seems like setPreventScreenDimming is the better name, but you are just using
this API.

> Source/WebKit/blackberry/Api/WebPage.cpp:5230
> +	   d->m_page->settings()->setDeveloperExtrasEnabled(false);

Would be nice to make this call implicit.