[webkit-reviews] review denied: [Bug 102229] Add the --order option to NRWT : [Attachment 175490] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 21 13:55:48 PST 2012


Dirk Pranke <dpranke at chromium.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 102229: Add the --order option to NRWT
https://bugs.webkit.org/show_bug.cgi?id=102229

Attachment 175490: Patch
https://bugs.webkit.org/attachment.cgi?id=175490&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
Close. Making Port.split_test a static method seems to defeat the point of the
abstraction, and it doesn't seem like it's really needed anywhere? Looks fine
otherwise, though.


More information about the webkit-reviews mailing list