[webkit-reviews] review granted: [Bug 102886] HTMLCollection should use the same storage as DynamicNodeList : [Attachment 175502] Fixed GTK+ & FEL builds

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 102886: HTMLCollection should use the same storage as DynamicNodeList
https://bugs.webkit.org/show_bug.cgi?id=102886

Attachment 175502: Fixed GTK+ & FEL builds
https://bugs.webkit.org/attachment.cgi?id=175502&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=175502&action=review


r=me

> Source/WebCore/dom/NodeRareData.h:82
> +	   NodeListAtomicNameCacheMap::AddResult result =
m_atomicNameCaches.add(
> +	   namedNodeListKey(DynamicNodeList::PastLastNodeListType +
collectionType - FirstNodeCollectionType, starAtom), 0);

This spills awkwardly to the next line. You should just construct the key on a
separate line.

> Source/WebCore/dom/NodeRareData.h:94
> +	   return
static_cast<T*>(m_atomicNameCaches.get(namedNodeListKey(DynamicNodeList::PastLa
stNodeListType + type - FirstNodeCollectionType, starAtom)));

This is pretty long too.