[webkit-reviews] review denied: [Bug 82169] [Shadow DOM] Implements a /select/ reference combinator : [Attachment 175404] Ready for review. Let me file another bugs later.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 21 11:05:56 PST 2012
Antti Koivisto <koivisto at iki.fi> has denied Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 82169: [Shadow DOM] Implements a /select/ reference combinator
https://bugs.webkit.org/show_bug.cgi?id=82169
Attachment 175404: Ready for review. Let me file another bugs later.
https://bugs.webkit.org/attachment.cgi?id=175404&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=175404&action=review
I agree with Ojan, a webkit-dev post would be a good idea. The standardization
status of this is also unclear to me. How much review has this received?
> Source/WebCore/css/CSSGrammar.y.in:1012
> +reference_combinator:
> + '/' IDENT '/' maybe_space {
> + CSSParserString& str = $2;
> + if (parser->m_context.isHTMLDocument)
> + str.lower();
> + $$ = str;
> + }
> + ;
Please put this feature fully behind a feature flag, ENABLE(SHADOW_DOM)
probably.
More information about the webkit-reviews
mailing list