[webkit-reviews] review granted: [Bug 102939] [chromium] Change default tap highlight color for Chromium Windows & Linux. : [Attachment 175438] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 102939: [chromium] Change default tap highlight color for Chromium Windows
& Linux.
https://bugs.webkit.org/show_bug.cgi?id=102939

Attachment 175438: Patch
https://bugs.webkit.org/attachment.cgi?id=175438&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175438&action=review


> Source/WebCore/rendering/RenderThemeChromiumSkia.h:50
> +	   virtual Color platformTapHighlightColor() const OVERRIDE

The indent in this file is really odd.

Does it matter that defaultTapHighlightColor has type RGBA32 and the return
type of this function is Color?

> Source/WebCore/rendering/RenderThemeChromiumSkia.h:52
> +	       return RenderThemeChromiumSkia::defaultTapHighlightColor;

I'm surprised that "RenderThemeChromiumSkia::" is necessary.