[webkit-reviews] review granted: [Bug 102941] IDBRequestTest needs a v8 context : [Attachment 175441] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 21 07:35:02 PST 2012


jochen at chromium.org has granted Dan Carney <dcarney at google.com>'s request for
review:
Bug 102941: IDBRequestTest needs a v8 context
https://bugs.webkit.org/show_bug.cgi?id=102941

Attachment 175441: Patch
https://bugs.webkit.org/attachment.cgi?id=175441&action=review

------- Additional Comments from jochen at chromium.org
View in context: https://bugs.webkit.org/attachment.cgi?id=175441&action=review


> Source/WebKit/chromium/tests/IDBRequestTest.cpp:68
> +    v8::Handle<v8::Context> context()

can you call this v8Context() so it doesn't collide with the variables named
"context" in the test?


More information about the webkit-reviews mailing list