[webkit-reviews] review requested: [Bug 102534] [chromium] Add flag to enable/disable touch adjustment at runtime. : [Attachment 175274] Patch

[bugzilla-daemon at webkit.org]

Kevin Ellis <kevers at chromium.org> has asked  for review:
Bug 102534: [chromium] Add flag to enable/disable touch adjustment at runtime.
https://bugs.webkit.org/show_bug.cgi?id=102534

Attachment 175274: Patch
https://bugs.webkit.org/attachment.cgi?id=175274&action=review

------- Additional Comments from Kevin Ellis <kevers at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175274&action=review


>> Source/WebCore/ChangeLog:9
>> +
> 
> You should mention here why the compile time only flag is not enough. Things
like when compile-time would be enabled, but the run-time setting disable, etc.


Done.

>> Source/WebCore/page/EventHandler.cpp:2701
>> +bool EventHandler::shouldApplyTouchAdjustment(const PlatformGestureEvent&
event)
> 
> const?

Done.

>> Source/WebCore/page/Settings.in:143
>> +touchAdjustmentEnabled initial=true
> 
> default true? How does it work when the compile flag is disabled? Do we care?
Found it a bit odd ...

Added comment to indicate that both the compile option is also required to
enable touch adjustment.  This option provides dynamic control to disable touch
adjustment as required at run-time.