[webkit-reviews] review denied: [Bug 102906] Web Inspector: Ctrl+A closes breakpoint condition editor : [Attachment 175390] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 102906: Web Inspector: Ctrl+A closes breakpoint condition editor
https://bugs.webkit.org/show_bug.cgi?id=102906

Attachment 175390: Patch
https://bugs.webkit.org/attachment.cgi?id=175390&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175390&action=review


>> Source/WebCore/inspector/front-end/DefaultTextEditor.js:421
>> +	    if (WebInspector.currentFocusElement().nodeName === "INPUT")
> 
> call WebInspector.isBeingEdited(e.target) maybe?

You can edit text in non-INPUT fields as well. Imagine if we switch conditional
breakpoints to the text area... You should check that e.target has no ancestors
with className "webkit-line-decorations" instead.