[webkit-reviews] review denied: [Bug 102794] Fix QNX Qt build by enabling JIT. : [Attachment 175188] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 21 04:08:13 PST 2012


Simon Hausmann <hausmann at webkit.org> has denied Sergio Martins
<sergio.martins at kdab.com>'s request for review:
Bug 102794: Fix QNX Qt build by enabling JIT.
https://bugs.webkit.org/show_bug.cgi?id=102794

Attachment 175188: Patch
https://bugs.webkit.org/attachment.cgi?id=175188&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175188&action=review


> Source/WTF/wtf/Platform.h:1008
> +#if !defined(ENABLE_YARR_JIT) && (ENABLE(JIT) || ENABLE(LLINT_C_LOOP)) &&
!PLATFORM(CHROMIUM) && !(OS(QNX) && PLATFORM(QT))

This change is missing a ChangeLog and I don't understand why this part is
necessary (no changelog ;)

If you enable the JIT, why not also enable YARR_JIT?


More information about the webkit-reviews mailing list