[webkit-reviews] review granted: [Bug 102845] Make it possible for elements with different tag names to share attribute data. : [Attachment 175295] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 102845: Make it possible for elements with different tag names to share
attribute data.
https://bugs.webkit.org/show_bug.cgi?id=102845

Attachment 175295: Patch
https://bugs.webkit.org/attachment.cgi?id=175295&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=175295&action=review


> Source/WebCore/ChangeLog:25
> +	   On the upside, excluding elements with presentation attributes from
the data cache means that
> +	   we can move one pointer (m_presentationAttributeStyle) from
ImmutableElementAttributeData
> +	   to MutableElementAttributeData.

I suppose we could also add 3rd state,
ImmutableElementAttributeDataWithPresentationAttributeStyle. Might not be worth
it.