[webkit-reviews] review granted: [Bug 102870] [V8] Replace V8Parameter::prepare() with V8Parameter::operator=() : [Attachment 175334] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 102870: [V8] Replace V8Parameter::prepare() with V8Parameter::operator=()
https://bugs.webkit.org/show_bug.cgi?id=102870

Attachment 175334: Patch
https://bugs.webkit.org/attachment.cgi?id=175334&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175334&action=review


> Source/WebCore/bindings/v8/V8BindingMacros.h:71
> -    type var(value); 						\
> +    type var;							\
>      {								\
>	   v8::TryCatch block;						\
> -	   var.prepare();						\
> +	   var = (value);						\

Does it matter that you're moving the evaluation of (value) inside the TryCatch
block?	Perhaps it matters if evaluating (value) throws an exception?