[webkit-reviews] review granted: [Bug 102850] Web Inspector: IndexedDB: remove setVersion from inspector tests : [Attachment 175305] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 102850: Web Inspector: IndexedDB: remove setVersion from inspector tests
https://bugs.webkit.org/show_bug.cgi?id=102850

Attachment 175305: Patch
https://bugs.webkit.org/attachment.cgi?id=175305&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175305&action=review


> LayoutTests/http/tests/inspector/indexeddb/database-structure-expected.txt:23

> +    version: 

If I understand correctly, the version field should go now? Would you care to
remove it from test (and expectations)?
Just remove line 22 in database-structure.html:    InspectorTest.addResult("   
version: " + database.version);

> LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js:145
> +	   request.onupgradeneeded = function(e) {

We prefer named function style in inspector (and "{" should go to the next
line):

request.onupgradeneeded = onUpgradeNeeded;

function onUpgradeNeeded(e)
{
    ...
}