[webkit-reviews] review granted: [Bug 102854] [V8] Unify the Node and non-Node code paths for getting JavaScript wrappers : [Attachment 175319] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 102854: [V8] Unify the Node and non-Node code paths for getting JavaScript
wrappers
https://bugs.webkit.org/show_bug.cgi?id=102854

Attachment 175319: Patch
https://bugs.webkit.org/attachment.cgi?id=175319&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175319&action=review


> Source/WebCore/ChangeLog:10
> +	   should not be as fast to access as Nodes were previously.

should now?

> Source/WebCore/ChangeLog:26
> +		 DOM object has a wrapper both on the main thread and on a
worker
> +		 thread, we'll have a write conflict as both threads will want
to
> +		 store the wrapper inline in the object.

We have an ASSERT to catch that, no?