[webkit-reviews] review granted: [Bug 102852] 7% regression in dromaeo_domcorequery/dom_query_getElementsByTagName__not_in_document : [Attachment 175310] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 102852: 7% regression in
dromaeo_domcorequery/dom_query_getElementsByTagName__not_in_document
https://bugs.webkit.org/show_bug.cgi?id=102852

Attachment 175310: Patch
https://bugs.webkit.org/attachment.cgi?id=175310&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175310&action=review


Looks reasonable.

> Source/WebCore/bindings/v8/DOMDataStore.cpp:65
> +	   V8DOMWindowShell* shell =
V8DOMWindowShell::isolated(v8::Context::GetEntered());
> +	   if (UNLIKELY(!!shell))
> +	       return shell->world()->isolatedWorldDOMDataStore();

Maybe you can simplify the code by using worldForEnteredContextIfIsolated()?